hey 👋🏻

Is there still something missing?

• I wanted to wait for the PR Luca opened to get merged first to see if there'd be any other updates there, but I think it's already in.
• I noticed some "issues" with transactions/cdi contexts and repositories so wanted to check with Gavin to see what he thinks about it HHH-19109 fix use of @TransactionScoped by repository hibernate/hibernate-orm#9855 (comment). but now as it got changed (hibernate/hibernate-orm@e0c81b9) I'm not sure whether to wait for that update to be released or leave things as they currently are in this PR.
• Guillaume had that suggestion for the readme, so I was just waiting to see what Guillaume and you decide that we want to do here 😃

Other than that ... 🟢 😃

hey 👋🏻

Is there still something missing?

* I wanted to wait for the PR Luca opened to get merged first to see if there'd be any other updates there, but I think it's already in.

It's in.

* I noticed some "issues" with transactions/cdi contexts and repositories so wanted to check with Gavin to see what he thinks about it [HHH-19109 fix use of @TransactionScoped by repository hibernate/hibernate-orm#9855 (comment)](https://github.com/hibernate/hibernate-orm/pull/9855#discussion_r2050448996). but now as it got changed ([hibernate/hibernate-orm@e0c81b9](https://github.com/hibernate/hibernate-orm/commit/e0c81b97ecfa8ad54fda498f0196fa545be76c51)) I'm not sure whether to wait for that update to be released or leave things as they currently are in this PR.

The best practice is to use @Transactional everywhere. You can put it on the REST Resource class if that's easier. I wouldn't worry about other (@Transactional-less) use cases for this PR.

* Guillaume had that suggestion for the readme, so I was just waiting to see what Guillaume and you decide that we want to do here 😃

He suggested to remove it, IIRC? Or at least replace it with just a title + link to docs. Fine by me, but should be a separate PR that would need to address all Hibernate quickstarts. So it's fine to merge your PR as is.

So... merging :)

@marko-bekhta Did you link to this quickstart from the Quarkus docs? You probably should, otherwise nobody will notice it :)

You probably should

thanks for the suggestion 😃 will send a PR later 👍🏻